Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework 'Understanding the tables' #629

Merged
merged 17 commits into from
Sep 17, 2023
Merged

Rework 'Understanding the tables' #629

merged 17 commits into from
Sep 17, 2023

Conversation

burnash
Copy link
Collaborator

@burnash burnash commented Sep 13, 2023

Description

This PR extends the "Understanding the tables" documentation page with more examples and explicit description of database objects created in the destination database.

@netlify
Copy link

netlify bot commented Sep 13, 2023 •
edited
Loading

✅ Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit 5e156ed
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/6504b6b6a072d800085deebe
😎 Deploy Preview https://deploy-preview-629--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@burnash
Copy link
Collaborator Author

burnash commented Sep 13, 2023

@rudolfix ready for a review. I've added a section about full_refresh as is but I expect it to change soon once #588 gets implemented. Also found in the docs that we use the same term "Full refresh" for other things like using replace write disposition after append or merge in Doing a full refresh and Do a full refresh. This could be misleading for someone new. I suggest to rename these sections to avoid confusion. Maybe "Loading data anew"?

@burnash burnash requested a review from rudolfix September 13, 2023 19:06
rudolfix
rudolfix approved these changes Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is excellent!

rudolfix
rudolfix requested changes Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comment on full refresh

docs/website/docs/dlt-ecosystem/visualizations/understanding-the-tables.md Outdated Show resolved Hide resolved
@burnash burnash requested a review from rudolfix September 15, 2023 20:03
rudolfix
rudolfix approved these changes Sep 17, 2023
View reviewed changes
Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent!

@burnash burnash merged commit 6806f5a into devel Sep 17, 2023
34 checks passed
@AstrakhantsevaAA AstrakhantsevaAA deleted the enh/docs_improve_understanding_the_tables branch October 19, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AstrakhantsevaAA AstrakhantsevaAA AstrakhantsevaAA left review comments

@rudolfix rudolfix rudolfix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@burnash @rudolfix @AstrakhantsevaAA